Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/5964#issuecomment-105684510
Mostly I care about separating (1), since it seems like its handling is
totally separate from the other issues; can you put the fix to that in its own
pull request (or move the other changes into their own pull request)? For that
issue, it seems possible to write a narrow unit test to test the specific issue
(I wrote two such tests here that you should be able to mostly re-use, if you
like:
https://github.com/kayousterhout/spark-1/commit/2b7d23299251a858f13e600d58bb616bf38d7c73;
the first test passes but the second one fails with the current code). I find
that preferable to the end-to-end test that you wrote, since it makes it easier
to debug the issue when the test fails, and the test also runs much more
quickly.
I'm also a little confused about how this fixes (1), as I commented on in
the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
