HyukjinKwon commented on code in PR #43894:
URL: https://github.com/apache/spark/pull/43894#discussion_r1398562718
##########
python/pyspark/sql/connect/utils.py:
##########
@@ -44,14 +46,39 @@ def require_minimum_grpc_version() -> None:
import grpc
except ImportError as error:
raise ImportError(
- "grpcio >= %s must be installed; however, " "it was not found." %
minimum_grpc_version
+ f"grpcio >= {minimum_grpc_version} must be installed; however, it
was not found."
) from error
if LooseVersion(grpc.__version__) < LooseVersion(minimum_grpc_version):
raise ImportError(
- "grpcio >= %s must be installed; however, "
- "your version was %s." % (minimum_grpc_version, grpc.__version__)
+ f"grpcio >= {minimum_grpc_version} must be installed; however, "
+ f"your version was {grpc.__version__}."
)
+def require_minimum_grpcio_status_version() -> None:
+ """Raise ImportError if grpcio-status is not installed"""
+ minimum_grpc_version = "1.48.1"
+
+ try:
+ import grpc_status
Review Comment:
This and below do not have `__version__` attributes ... interestingly ..
##########
dev/requirements.txt:
##########
@@ -54,7 +54,7 @@ py
grpcio>=1.48,<1.57
grpcio-status>=1.48,<1.57
protobuf==4.25.1
-googleapis-common-protos==1.56.4
+googleapis-common-protos>=1.56.4
Review Comment:
According to `setup.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
