LuciferYang commented on PR #43904: URL: https://github.com/apache/spark/pull/43904#issuecomment-1818448719
> > Is the maintenance cost high if these two patches are backported to branch-3.x? > > I think so, BTW we already adopt such way to fix python linter: > > ``` > - name: Install Python linter dependencies for branch-3.3 > if: inputs.branch == 'branch-3.3' > run: ... > - name: Install Python linter dependencies for branch-3.4 > if: inputs.branch == 'branch-3.4' > run: ... > - name: Install Python linter dependencies for branch-3.5 > if: inputs.branch == 'branch-3.5' > run: ... > - name: Install Python linter dependencies > if: inputs.branch != 'branch-3.3' && inputs.branch != 'branch-3.4' && inputs.branch != 'branch-3.5' > run: ... > - name: Python linter > run: PYTHON_EXECUTABLE=python3.9 ./dev/lint-python > - name: Install dependencies for Python code generation check > if: inputs.branch != 'branch-3.3' && inputs.branch != 'branch-3.4' > run: ... > ``` OK, this pr is fine to me :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
