tgravescs commented on code in PR #43863: URL: https://github.com/apache/spark/pull/43863#discussion_r1399416651
########## docs/running-on-kubernetes.md: ########## @@ -1650,6 +1650,27 @@ See the [configuration page](configuration.html) for information on Spark config </td> <td>3.3.0</td> </tr> +<tr> + <td><code>spark.executor.maxNumFailures</code></td> Review Comment: these should not be in the kubernetes docuemntation since its not specific to k8s, the generic configuration.md cover this. Please just remove these ########## docs/running-on-yarn.md: ########## @@ -292,12 +292,12 @@ To use a custom metrics.properties for the application master and executors, upd <td>1.4.0</td> </tr> <tr> - <td><code>spark.yarn.max.executor.failures</code></td> + <td><code>spark.executor.maxNumFailures</code></td> Review Comment: So these should just be removed from here and not changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
