cloud-fan commented on code in PR #43843:
URL: https://github.com/apache/spark/pull/43843#discussion_r1400019360
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -969,6 +973,8 @@ primaryExpression
| LAST LEFT_PAREN expression (IGNORE NULLS)? RIGHT_PAREN
#last
| POSITION LEFT_PAREN substr=valueExpression IN str=valueExpression
RIGHT_PAREN #position
| constant
#constantDefault
+ | ASTERISK EXCEPT LEFT_PAREN exceptCols=multipartIdentifierList
RIGHT_PAREN #starExcept
+ | qualifiedName DOT ASTERISK EXCEPT LEFT_PAREN
exceptCols=multipartIdentifierList RIGHT_PAREN #starExcept
| ASTERISK
#star
Review Comment:
how about `ASTERISK exceptClause?`
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -969,6 +973,8 @@ primaryExpression
| LAST LEFT_PAREN expression (IGNORE NULLS)? RIGHT_PAREN
#last
| POSITION LEFT_PAREN substr=valueExpression IN str=valueExpression
RIGHT_PAREN #position
| constant
#constantDefault
+ | ASTERISK EXCEPT LEFT_PAREN exceptCols=multipartIdentifierList
RIGHT_PAREN #starExcept
+ | qualifiedName DOT ASTERISK EXCEPT LEFT_PAREN
exceptCols=multipartIdentifierList RIGHT_PAREN #starExcept
| ASTERISK
#star
| qualifiedName DOT ASTERISK
#star
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
