LuciferYang commented on PR #43717: URL: https://github.com/apache/spark/pull/43717#issuecomment-1820873259
@beliefer I think the fix for `Replace .size with .length on arrays and strings` is worth it. `Array` and `String` are both native objects of Java, and `length` is Java method. The 'size' function (defined in `ArrayOps` and `StringOps`) is a proxy for the `length` method. Directly using `length` can reduce the call stack, and I think we can fix all of this case in one pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
