justaparth commented on code in PR #43767:
URL: https://github.com/apache/spark/pull/43767#discussion_r1400822484
##########
connector/protobuf/src/test/resources/protobuf/functions_suite.proto:
##########
@@ -324,3 +325,19 @@ message Proto3AllTypes {
}
map<string, string> map = 13;
}
+
+message WellKnownWrapperTypes {
+ google.protobuf.BoolValue bool_val = 1;
+ google.protobuf.Int32Value int32_val = 2;
Review Comment:
yeah, great suggestion. I added that test!
basically the internal `value` field should operate the same as any
primitive, and when unwrapping it should unwrap that value correctly. I added a
test that confirms every configuration of emit.default.values and
unwrap.primitive.wrapper.types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
