dongjoon-hyun commented on code in PR #43914:
URL: https://github.com/apache/spark/pull/43914#discussion_r1401189449
##########
core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala:
##########
@@ -119,7 +119,8 @@ object EventLogFileReader extends Logging {
if (isSingleEventLog(status)) {
Some(new SingleFileEventLogFileReader(fs, status.getPath,
Option(status)))
} else if (isRollingEventLogs(status)) {
- if
(fs.listStatus(status.getPath).exists(RollingEventLogFilesWriter.isEventLogFile))
{
+ if
(fs.listStatus(status.getPath).exists(RollingEventLogFilesWriter.isEventLogFile)
&&
+
fs.listStatus(status.getPath).exists(RollingEventLogFilesWriter.isAppStatusFile))
{
Review Comment:
This is intentional because we cannot merge them, @mridulm , @LuciferYang ,
@HyukjinKwon .
I guess the suggestion is `.exists(RollingEventLogFilesWriter.isEventLogFile
|| RollingEventLogFilesWriter.isAppStatusFile)`, right? In that case, we still
cannot catch a missing app status file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
