rangadi commented on code in PR #43851:
URL: https://github.com/apache/spark/pull/43851#discussion_r1401213571
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2611,8 +2613,17 @@ class SparkConnectPlanner(
.setSqlCommandResult(result)
.build())
- // Send Metrics
-
responseObserver.onNext(MetricGenerator.createMetricsResponse(sessionHolder,
df))
+ // Send Metrics when isCommand (i.e. show tables) which is eagerly
executed & has metrics
Review Comment:
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
