cloud-fan commented on code in PR #43938:
URL: https://github.com/apache/spark/pull/43938#discussion_r1402867108
##########
sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala:
##########
@@ -1755,4 +1755,27 @@ class JoinSuite extends QueryTest with
SharedSparkSession with AdaptiveSparkPlan
cached.unpersist()
}
}
+
+ test("SPARK-46037: When Left Join build Left, ShuffledHashJoinExec may " +
+ "result in incorrect results") {
+ withSQLConf(SQLConf.ENABLE_BUILD_SIDE_OUTER_SHUFFLED_HASH_JOIN_CODEGEN.key
-> "false") {
+ val df1 = sql(
+ """
+ |SELECT /*+ SHUFFLE_HASH(t1) */ *
Review Comment:
In the golden file test `outer-join.sql`, we run it multiple times to test
different code paths: broadcast join, shuffle join, sort merge join. code
on/off etc., can we move the test there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
