itholic commented on code in PR #43996:
URL: https://github.com/apache/spark/pull/43996#discussion_r1403912488
##########
python/pyspark/pandas/supported_api_gen.py:
##########
@@ -142,7 +142,7 @@ def _create_supported_by_module(
[
m
for m in getmembers(pd_module, isfunction)
- if not m[0].startswith("_") and m[0] in pd_module.__dict__
Review Comment:
`inspect.getmembers` returns all functions supported by the module,
including those inherited from parents, but `__dict__` only returns functions
directly implemented in the module, excluding inherited functions.
Therefore, the inherited and implemented API was treated as not supported in
the existing script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
