LuciferYang commented on PR #43997: URL: https://github.com/apache/spark/pull/43997#issuecomment-1825155658
> The variables exists primarily from pov of tests, and in that context, volatile is sufficient. Any particular reason to make them Atomic ? Yes, you're right. But there's a lack of mechanism here to ensure that it's always only serially accessed in tests in the future. Or at least we should add a comment to remind developers of the existence of this potential problem and under what circumstances it needs to be fixed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
