kuwii commented on code in PR #43646:
URL: https://github.com/apache/spark/pull/43646#discussion_r1404701377
##########
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala:
##########
@@ -93,16 +95,23 @@ abstract class HistoryServerSuite extends SparkFunSuite
with BeforeAndAfter with
.set(EXECUTOR_PROCESS_TREE_METRICS_ENABLED, true)
.set(HYBRID_STORE_DISK_BACKEND, diskBackend.toString)
conf.setAll(extraConf)
- provider = new FsHistoryProvider(conf)
- provider.checkForLogs()
+ val usedProvider = appHistoryProvider.getOrElse {
Review Comment:
Yes, to test whether history server returnscorrect response, the UT added in
this file requires to create history server service with a private
implementation of provider interface, to throw customized error. But current
version only creates `FsHistoryProvider`.
So change here is to allow to create pass private provider to initialization
method. The previous init way is still kept, so it won't affect other existing
tests.
##########
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala:
##########
@@ -93,16 +95,23 @@ abstract class HistoryServerSuite extends SparkFunSuite
with BeforeAndAfter with
.set(EXECUTOR_PROCESS_TREE_METRICS_ENABLED, true)
.set(HYBRID_STORE_DISK_BACKEND, diskBackend.toString)
conf.setAll(extraConf)
- provider = new FsHistoryProvider(conf)
- provider.checkForLogs()
+ val usedProvider = appHistoryProvider.getOrElse {
Review Comment:
Yes, to test whether history server returns correct response, the UT added
in this file requires to create history server service with a private
implementation of provider interface, to throw customized error. But current
version only creates `FsHistoryProvider`.
So change here is to allow to create pass private provider to initialization
method. The previous init way is still kept, so it won't affect other existing
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
