dongjoon-hyun commented on code in PR #44065:
URL: https://github.com/apache/spark/pull/44065#discussion_r1408617098


##########
python/pyspark/tests/test_worker.py:
##########
@@ -230,7 +230,7 @@ def conf(cls):
         _conf.set("spark.python.worker.faulthandler.enabled", "true")
         return _conf
 
-    @unittest.skipIf(sys.version_info > (3, 11), "SPARK-46130: Flaky with 
Python 3.12")
+    @unittest.skipIf(sys.version_info > (3, 12), "SPARK-46130: Flaky with 
Python 3.12")

Review Comment:
   To @HyukjinKwon , do we need to reevaluate every instances?
   
   ```
   $ git grep 'sys.version_info >'
   python/pyspark/pandas/__init__.py:    if sys.version_info >= (3, 7):
   python/pyspark/pandas/frame.py:        can_return_named_tuples = 
sys.version_info >= (3, 7) or len(self.columns) + index < 255
   python/pyspark/pandas/tests/computation/test_apply_func.py:        if 
sys.version_info >= (3, 8):
   python/pyspark/pandas/tests/test_typedef.py:            if sys.version_info 
>= (3, 8):
   python/pyspark/pandas/typedef/typehints.py:    if sys.version_info >= (3, 8):
   python/pyspark/sql/connect/_typing.py:if sys.version_info >= (3, 8):
   python/pyspark/sql/connect/proto/base_pb2.pyi:if sys.version_info >= (3, 10):
   python/pyspark/sql/connect/proto/catalog_pb2.pyi:if sys.version_info >= (3, 
8):
   python/pyspark/sql/connect/proto/commands_pb2.pyi:if sys.version_info >= (3, 
10):
   python/pyspark/sql/connect/proto/common_pb2.pyi:if sys.version_info >= (3, 
8):
   python/pyspark/sql/connect/proto/example_plugins_pb2.pyi:if sys.version_info 
>= (3, 8):
   python/pyspark/sql/connect/proto/expressions_pb2.pyi:if sys.version_info >= 
(3, 10):
   python/pyspark/sql/connect/proto/relations_pb2.pyi:if sys.version_info >= 
(3, 10):
   python/pyspark/sql/connect/proto/types_pb2.pyi:if sys.version_info >= (3, 8):
   python/pyspark/tests/test_worker.py:    @unittest.skipIf(sys.version_info > 
(3, 11), "SPARK-46130: Flaky with Python 3.12")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to