MaxGekk opened a new pull request, #44094:
URL: https://github.com/apache/spark/pull/44094

   ### What changes were proposed in this pull request?
   In the PR, I propose to change the implementation of interpretation mode of 
`StringDecode` and apparently of the `decode` function. And make it consistent 
to codegen. Both implementation raise the same error with of the error class 
`INVALID_PARAMETER_VALUE.CHARSET`.
   
   ### Why are the changes needed?
   To make codegen and non-codegen of the `StringDecode` expression consistent. 
So, users will observe the same behaviour in both modes.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes, if user code depends on error from `decode()`.
   
   ### How was this patch tested?
   By running the following test suites:
   ```
   $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly 
org.apache.spark.sql.SQLQueryTestSuite -- -z string-functions.sql"
   $ build/sbt "core/testOnly *SparkThrowableSuite"
   $ build/sbt "test:testOnly *.StringFunctionsSuite"
   ```
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to