juliuszsompolski commented on code in PR #44095:
URL: https://github.com/apache/spark/pull/44095#discussion_r1411243350
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala:
##########
@@ -128,13 +128,6 @@ private[connect] class ExecuteHolder(
runner.start()
}
- /**
- * Wait for the execution thread to finish and join it.
- */
- def join(): Unit = {
- runner.join()
- }
Review Comment:
wasn't used, and should be internal, let's reduce the surface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
