cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1413423471
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##########
@@ -317,32 +339,17 @@ class UnboundedOffsetWindowFunctionFrame(
offset: Int,
ignoreNulls: Boolean = false)
extends OffsetWindowFunctionFrameBase(
- target, ordinal, expressions, inputSchema, newMutableProjection, offset) {
+ target, ordinal, expressions, inputSchema, newMutableProjection, offset,
ignoreNulls) {
assert(offset > 0)
- override def prepare(rows: ExternalAppendOnlyUnsafeRowArray): Unit = {
- if (offset > rows.length) {
- fillDefaultValue(EmptyRow)
- } else {
- resetStates(rows)
- if (ignoreNulls) {
- findNextRowWithNonNullInput()
- if (nextSelectedRow == EmptyRow) {
- // Use default values since the offset row whose input value is not
null does not exist.
- fillDefaultValue(EmptyRow)
Review Comment:
This code logic is gone after refactor. Is it safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
