milastdbx commented on code in PR #44093:
URL: https://github.com/apache/spark/pull/44093#discussion_r1413975389


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -3909,6 +3943,11 @@ class AstBuilder extends DataTypeAstBuilder with 
SQLConfHelper with Logging {
     }
   }
 
+  /**
+   * Converts a string literal to a string.
+   */
+  protected def stringLitToStr(x: StringLitContext) = string(visitStringLit(x))

Review Comment:
   this logic is used in couple of places, i think it makes sense to isolate it 
in seperate method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to