dongjoon-hyun commented on code in PR #44172: URL: https://github.com/apache/spark/pull/44172#discussion_r1414892735
########## core/benchmarks/ZStandardBenchmark-results.txt: ########## @@ -2,26 +2,26 @@ Benchmark ZStandardCompressionCodec ================================================================================================ -OpenJDK 64-Bit Server VM 17.0.9+9-LTS on Linux 5.15.0-1051-azure -AMD EPYC 7763 64-Core Processor +OpenJDK 64-Bit Server VM 17.0.9+0 on Mac OS X 14.1.2 +Apple M2 Max Review Comment: You can regenerate the result in your CI. - https://github.com/apache/spark/actions/workflows/benchmark.yml ########## core/benchmarks/ZStandardBenchmark-results.txt: ########## @@ -2,26 +2,26 @@ Benchmark ZStandardCompressionCodec ================================================================================================ -OpenJDK 64-Bit Server VM 17.0.9+9-LTS on Linux 5.15.0-1051-azure -AMD EPYC 7763 64-Core Processor +OpenJDK 64-Bit Server VM 17.0.9+0 on Mac OS X 14.1.2 +Apple M2 Max Benchmark ZStandardCompressionCodec: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative -------------------------------------------------------------------------------------------------------------------------------------- -Compression 10000 times at level 1 without buffer pool 657 659 2 0.0 65716.9 1.0X -Compression 10000 times at level 2 without buffer pool 706 707 1 0.0 70617.1 0.9X -Compression 10000 times at level 3 without buffer pool 788 788 0 0.0 78755.6 0.8X -Compression 10000 times at level 1 with buffer pool 585 586 1 0.0 58455.1 1.1X -Compression 10000 times at level 2 with buffer pool 614 616 1 0.0 61437.2 1.1X -Compression 10000 times at level 3 with buffer pool 717 717 0 0.0 71705.1 0.9X +Compression 10000 times at level 1 without buffer pool 1573 1576 4 0.0 157331.9 1.0X +Compression 10000 times at level 2 without buffer pool 1907 1972 92 0.0 190663.7 0.8X +Compression 10000 times at level 3 without buffer pool 2004 2038 49 0.0 200351.7 0.8X +Compression 10000 times at level 1 with buffer pool 2223 2278 77 0.0 222348.1 0.7X +Compression 10000 times at level 2 with buffer pool 2376 2384 11 0.0 237598.2 0.7X +Compression 10000 times at level 3 with buffer pool 2357 2372 21 0.0 235745.3 0.7X -OpenJDK 64-Bit Server VM 17.0.9+9-LTS on Linux 5.15.0-1051-azure -AMD EPYC 7763 64-Core Processor +OpenJDK 64-Bit Server VM 17.0.9+0 on Mac OS X 14.1.2 +Apple M2 Max Review Comment: ditto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org