LuciferYang commented on code in PR #44172:
URL: https://github.com/apache/spark/pull/44172#discussion_r1415092650


##########
core/src/test/scala/org/apache/spark/io/ZStandardBenchmark.scala:
##########
@@ -101,4 +102,28 @@ object ZStandardBenchmark extends BenchmarkBase {
       }
     }
   }
+
+  private def parallelCompressionBenchmark(): Unit = {
+    val N = 128
+    val data = (1 until 128 * 1024 * 1024).toArray
+
+    Seq(3, 9).foreach { level =>
+      val benchmark = new Benchmark(s"Parallel Compression at level $level", 
N, output = output)
+      Seq(0, 1, 2, 4, 8, 16).foreach { workers =>

Review Comment:
   IIRC, the GitHub Action runner only has 2 CPU cores, and I'm not sure if 
testing with more workers at this time would yield meaningful test data(Will 
having more workers lead to the CPU being busy with context switching?).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to