LuciferYang commented on code in PR #44179:
URL: https://github.com/apache/spark/pull/44179#discussion_r1415263533
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala:
##########
@@ -417,7 +417,7 @@ case class StructType(fields: Array[StructField]) extends
DataType with Seq[Stru
override def defaultSize: Int = fields.map(_.dataType.defaultSize).sum
override def simpleString: String = {
- val fieldTypes = fields.view.map(field =>
s"${field.name}:${field.dataType.simpleString}").toSeq
+ val fieldTypes = fields.map(field =>
s"${field.name}:${field.dataType.simpleString}").toSeq
Review Comment:
No, The `.toSeq` will trigger computation, so this view doesn't achieve its
intended effect, unless we refactor the `truncatedString` method to accept
`SeqView` instead of `Seq`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
