itholic commented on code in PR #44186:
URL: https://github.com/apache/spark/pull/44186#discussion_r1415450791
##########
python/pyspark/pandas/tests/test_numpy_compat.py:
##########
@@ -26,21 +26,17 @@
class NumPyCompatTestsMixin:
blacklist = [
- # Koalas does not currently support
+ # Pandas-on-Spark does not currently support
"conj",
"conjugate",
"isnat",
"matmul",
"frexp",
# Values are close enough but tests failed.
- "arccos",
- "exp",
- "expm1",
"log", # flaky
"log10", # flaky
"log1p", # flaky
"modf",
- "floor_divide", # flaky
Review Comment:
For flaky tests, I manually ran whole tests 50 times on local.
`floor_divide` has never failed, so I enabled it.
Other flaky functions failed at least once, so I did not enable them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
