Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6405#discussion_r31106159
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -69,23 +63,28 @@ case class Sqrt(child: Expression) extends
UnaryExpression {
}
}
-abstract class BinaryArithmetic extends BinaryExpression {
- self: Product =>
-
- type EvaluatedType = Any
-
- override lazy val resolved =
- left.resolved && right.resolved &&
- left.dataType == right.dataType &&
- !DecimalType.isFixed(left.dataType)
+/**
+ * A function that get the absolute value of the numeric value.
+ */
+case class Abs(child: Expression) extends UnaryNumeric {
+ override def toString: String = s"Abs($child)"
- override def dataType: DataType = {
- if (!resolved) {
- throw new UnresolvedException(this,
- s"datatype. Can not resolve due to differing types
${left.dataType}, ${right.dataType}")
+ override def eval(input: Row): Any = {
+ val evalE = child.eval(input)
+ if (evalE == null) {
+ null
+ } else {
+ numeric.abs(evalE)
}
- left.dataType
}
+}
+
+abstract class BinaryArithmetic extends BinaryExpression
+ with TypeEqualConstraint { self: Product =>
+
+ type EvaluatedType = Any
--- End diff --
note i'm removing evalutedtype in https://github.com/apache/spark/pull/6427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
