LuciferYang commented on code in PR #43642:
URL: https://github.com/apache/spark/pull/43642#discussion_r1416714807
##########
examples/src/main/scala/org/apache/spark/examples/graphx/Analytics.scala:
##########
@@ -51,7 +51,7 @@ object Analytics {
case _ => throw new IllegalArgumentException(s"Invalid argument: $arg")
}
}
- val options = mutable.Map(optionsList: _*)
+ val options = mutable.Map(immutable.ArraySeq.unsafeWrapArray(optionsList):
_*)
Review Comment:
> oh, because `examples` do not depend on common/utils
`common/utils` is a transitive dependency of the `core` module, so
`ArrayImplicits ` is visible to the `examples` module, I previously suggested
this only because I believe that `private[spark]` code should not be part of
the examples. In this context, what is your suggestion? @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
