beliefer commented on code in PR #44310:
URL: https://github.com/apache/spark/pull/44310#discussion_r1423598716
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -769,7 +769,9 @@ object LimitPushDown extends Rule[LogicalPlan] {
LocalLimit(exp, project.copy(child = pushLocalLimitThroughJoin(exp,
join)))
// Push down limit 1 through Aggregate and turn Aggregate into Project if
it is group only.
case Limit(le @ IntegerLiteral(1), a: Aggregate) if a.groupOnly =>
- Limit(le, Project(a.aggregateExpressions, LocalLimit(le, a.child)))
+ val project = Project(a.aggregateExpressions, LocalLimit(le, a.child))
+ project.setTagValue(Project.dataOrderIrrelevantTag, ())
Review Comment:
According to the `EliminateSorts`, it's data order relevant if only group
expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
