LuciferYang commented on code in PR #44270:
URL: https://github.com/apache/spark/pull/44270#discussion_r1423861669
##########
common/network-common/src/main/java/org/apache/spark/network/TransportContext.java:
##########
@@ -272,8 +272,9 @@ private SSLFactory createSslFactory() {
conf.sslRpctrustStoreReloadIntervalMs())
.build();
} else {
- logger.error("RPC SSL encryption enabled but keys not found!" +
- "Please ensure the configured keys are present.");
+ logger.error("""
+ RPC SSL encryption enabled but keys not found!\
Review Comment:
Indentation?
##########
common/network-common/src/main/java/org/apache/spark/network/server/TransportChannelHandler.java:
##########
@@ -162,10 +162,11 @@ public void userEventTriggered(ChannelHandlerContext ctx,
Object evt) throws Exc
if (e.state() == IdleState.ALL_IDLE && isActuallyOverdue) {
if (responseHandler.hasOutstandingRequests()) {
String address = getRemoteAddress(ctx.channel());
- logger.error("Connection to {} has been quiet for {} ms while
there are outstanding " +
- "requests. Assuming connection is dead; please adjust" +
- " spark.{}.io.connectionTimeout if this is wrong.",
- address, requestTimeoutNs / 1000 / 1000,
transportContext.getConf().getModuleName());
+ logger.error("""
+ Connection to {} has been quiet for {} ms while there are
outstanding requests. \
Review Comment:
`{}` will not be replaced by parameters in the `formatted`, right?
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -281,14 +284,14 @@ AppShufflePartitionInfo
getOrCreateAppShufflePartitionInfo(
return newAppShufflePartitionInfo(appShuffleInfo, shuffleId,
shuffleMergeId, reduceId,
dataFile, indexFile, metaFile);
} catch (IOException e) {
- logger.error("{} attempt {} shuffle {} shuffleMerge {}: cannot create
merged shuffle " +
- "partition with data file {}, index file {}, and meta file {}",
appShuffleInfo.appId,
- appShuffleInfo.attemptId, shuffleId, shuffleMergeId,
dataFile.getAbsolutePath(),
- indexFile.getAbsolutePath(), metaFile.getAbsolutePath());
- throw new RuntimeException(
- String.format("Cannot initialize merged shuffle partition for appId
%s shuffleId %s "
- + "shuffleMergeId %s reduceId %s", appShuffleInfo.appId,
shuffleId, shuffleMergeId,
- reduceId), e);
+ logger.error("""
Review Comment:
ditto
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -247,9 +248,11 @@ AppShufflePartitionInfo getOrCreateAppShufflePartitionInfo(
AppAttemptShuffleMergeId currrentAppAttemptShuffleMergeId =
new AppAttemptShuffleMergeId(appShuffleInfo.appId,
appShuffleInfo.attemptId,
shuffleId, latestShuffleMergeId);
- logger.info("{}: creating a new shuffle merge metadata since
received " +
- "shuffleMergeId {} is higher than latest shuffleMergeId {}",
- currrentAppAttemptShuffleMergeId, shuffleMergeId,
latestShuffleMergeId);
+ logger.info("""
Review Comment:
ditto
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -228,9 +228,10 @@ AppShufflePartitionInfo getOrCreateAppShufflePartitionInfo(
AppShuffleMergePartitionsInfo shufflePartitionsWithMergeId =
shuffles.compute(shuffleId, (id, mergePartitionsInfo) -> {
if (mergePartitionsInfo == null) {
- logger.info("{} attempt {} shuffle {} shuffleMerge {}: creating a
new shuffle " +
- "merge metadata", appShuffleInfo.appId,
appShuffleInfo.attemptId, shuffleId,
- shuffleMergeId);
+ logger.info("""
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
