dongjoon-hyun commented on code in PR #44284:
URL: https://github.com/apache/spark/pull/44284#discussion_r1424370626
##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -676,6 +652,45 @@ private[deploy] class Master(
logInfo(f"Recovery complete in ${timeTakenNs / 1000000000d}%.3fs -
resuming operations!")
}
+ private[master] def handleRegisterWorker(
Review Comment:
Yes, the code is the same. I change the parameter of `handleRegisterWorker`
method from `RegisterWorker` class to field parameters to avoid side-effects.
##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -676,6 +652,45 @@ private[deploy] class Master(
logInfo(f"Recovery complete in ${timeTakenNs / 1000000000d}%.3fs -
resuming operations!")
}
+ private[master] def handleRegisterWorker(
Review Comment:
Yes, the code is the same. I change the parameter of `handleRegisterWorker`
method from a single `RegisterWorker` class to field parameters to avoid
side-effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
