srielau commented on PR #44335:
URL: https://github.com/apache/spark/pull/44335#issuecomment-1854656969
@MaxGekk
Is this just doing:
/**
* Gets a dialect exception, classifies it and wraps it by
`AnalysisException`.
* @param message The error message to be placed to the returned exception.
* @param e The dialect specific exception.
* @return `AnalysisException` or its sub-class.
*/
def classifyException(message: String, e: Throwable): AnalysisException = {
new AnalysisException(
errorClass = "_LEGACY_ERROR_TEMP_3064",
messageParameters = Map("msg" -> message),
cause = Some(e))
}
Shouldn't we raise proper error classes instead of hiding behind "message"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
