LuciferYang commented on code in PR #44343:
URL: https://github.com/apache/spark/pull/44343#discussion_r1426659839


##########
common/utils/src/main/scala/org/apache/spark/util/MavenUtils.scala:
##########
@@ -432,7 +443,7 @@ private[spark] object MavenUtils extends Logging {
         printStream.println(s"The jars for the packages stored in: 
$packagesDirectory")
         // scalastyle:on println
 
-        val ivy = Ivy.newInstance(ivySettings)
+        var ivy = Ivy.newInstance(ivySettings)

Review Comment:
   We can give it a new name below, no need to change it to 'var' here.
   
   



##########
common/utils/src/main/scala/org/apache/spark/util/MavenUtils.scala:
##########
@@ -454,9 +465,23 @@ private[spark] object MavenUtils extends Logging {
           md.addExcludeRule(createExclusion(e + ":*", ivySettings, 
ivyConfName))
         }
         // resolve dependencies
-        val rr: ResolveReport = ivy.resolve(md, resolveOptions)
+        var rr: ResolveReport = ivy.resolve(md, resolveOptions)

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to