yaooqinn commented on code in PR #43903:
URL: https://github.com/apache/spark/pull/43903#discussion_r1427469572


##########
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala:
##########
@@ -128,8 +128,15 @@ private[ui] class ExecutorThreadDumpPage(
 
   // scalastyle:off
   private def drawExecutorFlamegraph(request: HttpServletRequest, thread: 
Array[ThreadStackTrace]): Seq[Node] = {
+    val js =
+      s"""
+         |import {drawFlamegraph} from "/static/flamegraph.js";

Review Comment:
   It makes sense to me, let me fix this. Thank you, Hyukjin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to