cloud-fan commented on code in PR #44305:
URL: https://github.com/apache/spark/pull/44305#discussion_r1427550280
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala:
##########
@@ -708,17 +732,18 @@ object DataSource extends Logging {
def lookupDataSourceV2(provider: String, conf: SQLConf):
Option[TableProvider] = {
Review Comment:
It's not a followup... I have a concern about changing `lookupDataSource`
which is only used for the DS v1 path. Let's avoid the risk of breaking
anything. It's also less code change if we only instantiate the
`PythonTableProvider` here, so that the existing caller of `lookupDataSource`
can still instantiate the objects directly instead of calling the new
`newDataSourceInstance` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
