cloud-fan commented on code in PR #43661: URL: https://github.com/apache/spark/pull/43661#discussion_r1429566391
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/GeneralAggregateFunc.java: ########## @@ -41,6 +41,7 @@ * <li><pre>REGR_R2(input1, input2)</pre> Since 3.4.0</li> * <li><pre>REGR_SLOPE(input1, input2)</pre> Since 3.4.0</li> * <li><pre>REGR_SXY(input1, input2)</pre> Since 3.4.0</li> + * <li><pre>MODE(input1[, inverse])</pre> Since 4.0.0</li> Review Comment: This is very hacky. It's kind of we re-define the SQL semantic of the second parameter for MODE function only. Do we have existing examples? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
