nchammas commented on code in PR #43354:
URL: https://github.com/apache/spark/pull/43354#discussion_r1429570569
##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -2452,7 +2452,7 @@ package object config {
.createOptional
private[spark] val JAR_IVY_SETTING_PATH =
- ConfigBuilder("spark.jars.ivySettings")
+ ConfigBuilder(MavenUtils.JAR_IVY_SETTING_PATH_KEY)
Review Comment:
Isn't it more appropriate to have `MavenUtils` refer to this config entry
and get the key name?
It seems weird and breaks with the remaining configs for this config to get
its key name from somewhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
