faucct commented on code in PR #37749:
URL: https://github.com/apache/spark/pull/37749#discussion_r1430062134


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala:
##########
@@ -361,6 +361,18 @@ object KeyGroupedPartitioning {
       partitionValues: Seq[InternalRow]): KeyGroupedPartitioning = {
     KeyGroupedPartitioning(expressions, partitionValues.size, 
Some(partitionValues))
   }
+
+  def supportsExpressions(expressions: Seq[Expression]): Boolean = {

Review Comment:
   I have managed to execute a `SortMergeJoin` of data sources partitioned by 
`(SingleColumnTransform, SortedBucketTransform)` benefitting from the 
partitioning, but I have had to transform the DataSourceV2Relation to 
DataSourceV2ScanRelation myself and I think it is the only way because of this 
check. Could it be dropped?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to