HeartSaVioR commented on code in PR #43961:
URL: https://github.com/apache/spark/pull/43961#discussion_r1430758033
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -204,12 +211,18 @@ class RocksDB(
for (v <- loadedVersion + 1 to endVersion) {
var changelogReader: StateStoreChangelogReader = null
try {
- changelogReader = fileManager.getChangelogReader(v)
- changelogReader.foreach { case (key, value) =>
- if (value != null) {
- put(key, value)
- } else {
- remove(key)
+ changelogReader = fileManager.getChangelogReader(v, useColumnFamilies)
+ changelogReader.foreach { case (recordType, key, value, colFamilyName)
=>
Review Comment:
Then can we use the approach of tombstone like we did instead of adding a
huge overhead on recordType? Do you foresee multiple types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
