rezasafi commented on code in PR #44340:
URL: https://github.com/apache/spark/pull/44340#discussion_r1431003343


##########
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala:
##########
@@ -75,6 +75,10 @@ class EventLoggingListenerSuite extends SparkFunSuite with 
LocalSparkContext wit
     testApplicationEventLogging()
   }
 
+  test("End-to-end event logging with exit code") {
+    testEventLogging(exitCode = Some(0))

Review Comment:
   sure, i can add an explicit test, but since default is None, all other tests 
basically test exitCode = None



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to