cloud-fan commented on code in PR #44398:
URL: https://github.com/apache/spark/pull/44398#discussion_r1431363374
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala:
##########
@@ -66,6 +66,9 @@ private[sql] object H2Dialect extends JdbcDialect {
case _ => JdbcUtils.getCommonJDBCType(dt)
}
+ override def convertBigDecimalToDecimal(d: BigDecimal, precision: Int,
scale: Int): Decimal =
+ Decimal(d)
Review Comment:
This seems wrong. I think we should make sure the final `Decimal` instance
we return has the same precision and scale as the JDBC column type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
