HeartSaVioR commented on code in PR #43961:
URL: https://github.com/apache/spark/pull/43961#discussion_r1432198470
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -377,119 +380,247 @@ class RocksDBSuite extends
AlsoTestWithChangelogCheckpointingEnabled with Shared
}
}
- test("RocksDB: compression conf") {
- val remoteDir = Utils.createTempDir().toString
- new File(remoteDir).delete() // to make sure that the directory gets
created
+ Seq(true, false).foreach { useColumnFamilies =>
+ test(s"RocksDB: compression conf with
useColumnFamilies=$useColumnFamilies") {
+ val remoteDir = Utils.createTempDir().toString
+ new File(remoteDir).delete() // to make sure that the directory gets
created
- val conf = RocksDBConf().copy(compression = "zstd")
- withDB(remoteDir, conf = conf) { db =>
- assert(db.columnFamilyOptions.compressionType() ==
CompressionType.ZSTD_COMPRESSION)
- }
+ val conf = RocksDBConf().copy(compression = "zstd")
+ withDB(remoteDir, conf = conf, useColumnFamilies = useColumnFamilies) {
db =>
+ assert(db.columnFamilyOptions.compressionType() ==
CompressionType.ZSTD_COMPRESSION)
+ }
- // Test the default is LZ4
- withDB(remoteDir, conf = RocksDBConf().copy()) { db =>
- assert(db.columnFamilyOptions.compressionType() ==
CompressionType.LZ4_COMPRESSION)
+ // Test the default is LZ4
+ withDB(remoteDir, conf = RocksDBConf().copy(), useColumnFamilies =
useColumnFamilies) { db =>
+ assert(db.columnFamilyOptions.compressionType() ==
CompressionType.LZ4_COMPRESSION)
+ }
}
}
- test("RocksDB: get, put, iterator, commit, load") {
- def testOps(compactOnCommit: Boolean): Unit = {
- val remoteDir = Utils.createTempDir().toString
- new File(remoteDir).delete() // to make sure that the directory gets
created
+ Seq(true, false).foreach { useColumnFamilies =>
+ test(s"RocksDB: get, put, iterator, commit, load with " +
Review Comment:
I thought it was calling `testWithChangelogCheckpointingEnabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
