LuciferYang commented on code in PR #44211:
URL: https://github.com/apache/spark/pull/44211#discussion_r1433631481
##########
connector/kinesis-asl-assembly/pom.xml:
##########
@@ -62,12 +62,18 @@
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
- <version>2.6.1</version>
- <!--
- We are being explicit about version here and overriding the
- spark default of 2.5.0 because KCL appears to have introduced
- a dependency on protobuf 2.6.1 somewhere between KCL 1.4.0 and 1.6.1.
- -->
+ <scope>compile</scope>
Review Comment:
I'm glad to see that Kinesis can use the same version of protobuf-java as
other modules, but is this feasible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
