andylam-db commented on PR #44084: URL: https://github.com/apache/spark/pull/44084#issuecomment-1866762533
@jchen5 @agubichev @dtenedor Pinging for re-reviews :-) There's are quite a lot of changes since last time (read PR description). 1. I changed `CrossDbmsQueryTestSuite` to be an abstract class, and then `PostgreSQLQueryTestSuite` to extend that. 2. For `PostgreSQLQueryTestSuite`, the default input directory is `sql-tests/subquery`, to reduce the scope. In this PR, all files except for `exists-having.sql` are ignored, otherwise this PR would have 10K+ line changes, because I have to change the view creation syntax in these files a bit to be compatible with Postgres. 3. I added a docker file and bash script for easy installation and start of a Postgres container. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
