LuciferYang commented on code in PR #44444:
URL: https://github.com/apache/spark/pull/44444#discussion_r1434693808
##########
project/SparkBuild.scala:
##########
@@ -1373,6 +1373,7 @@ object Unidoc {
classpaths
.map(_.filterNot(_.data.getCanonicalPath.matches(""".*kafka-clients-0\.10.*""")))
.map(_.filterNot(_.data.getCanonicalPath.matches(""".*kafka_2\..*-0\.10.*""")))
+ .map(_.filterNot(_.data.getCanonicalPath.contains("apache-rat")))
Review Comment:
The following contents have been shaded in apache-rat-0.14.jar, but none of
them have been relocated:
```
org.apache.commons:commons-collections4:jar:4.4
org.apache.commons:commons-lang3:jar:3.12.0
commons-io:commons-io:jar:2.11.0
org.apache.commons:commons-compress:jar:1.25.0
commons-cli:commons-cli:jar:1.5.0
```
Since `apache-rat` is not a direct dependency of the project, it was
manually downloaded in `check-license`, I did not find a way to exclude it
through `DependencyOverrides` or `ExcludedDependencies`.
Another possible simple solution is to change `build_and_test.yml`, manually
delete `./lib/apache-rat-*.jar` after executing `check-license`.
@HyukjinKwon WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
