littlelittlewhite09 commented on code in PR #44448:
URL: https://github.com/apache/spark/pull/44448#discussion_r1435240715
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -2466,3 +2466,37 @@ object RemoveRepetitionFromGroupExpressions extends
Rule[LogicalPlan] {
}
}
}
+
+object EliminateCast extends Rule[LogicalPlan] {
Review Comment:
@HyukjinKwon Hi, I checked UnwrapCastInBinaryComparison, and this rule may
be applied on all filter conditions, including non-partitioned field, which may
cause some bug if modify this rule. Maybe, modifying the `convertFilters`
method in `HiveShim.scala` is a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
