panbingkun commented on PR #44293: URL: https://github.com/apache/spark/pull/44293#issuecomment-1868643987
> I agree with @yaooqinn . > > To @panbingkun , could you elaborate a little more about this? I don't understand what you meant by this. > > > To avoid misunderstandings caused by outdated items. 1.Some items in the `.rat-excludes` file no longer exist in the Spark code repo, such as `SparkIMain.scala`. Perhaps one day in the future, we may add a file named `SparkIMain.scala` (a new file with the `same file name` as the old file, but with a different meaning) due to some requirements. However, we did not add the required "License" header for this file. According to the current mechanism, it should pass the `check-license`, but this check may not be our original intention.In addition. 2.The `.rat-excludes` file seems to be constantly `adding` entries without a mechanism for `removing` them, which is not healthy for the file itself. The above is my personal opinion. If I understand it incorrectly, please correct me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
