viirya commented on code in PR #44496:
URL: https://github.com/apache/spark/pull/44496#discussion_r1436335619
##########
common/utils/src/main/scala/org/apache/spark/internal/Logging.scala:
##########
@@ -169,8 +169,8 @@ trait Logging {
}
Logging.sparkShellThresholdLevel = replLevel
rootLogger.getAppenders().asScala.foreach {
- case (_, ca: ConsoleAppender) =>
- ca.addFilter(new SparkShellLoggingFilter())
+ case (_, appender: AbstractAppender) =>
+ appender.addFilter(new SparkShellLoggingFilter())
Review Comment:
Doesn't this add the filter to all appenders of the root logger? I think the
original intention here is to only add the filter to console only. I think by
doing this, the logging of other appenders will be affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
