LuciferYang commented on code in PR #44500:
URL: https://github.com/apache/spark/pull/44500#discussion_r1436792932
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreLazyInitializationSuite.scala:
##########
@@ -32,6 +32,8 @@ class HiveMetastoreLazyInitializationSuite extends
SparkFunSuite {
.master("local[2]")
.enableHiveSupport()
.config("spark.hadoop.hive.metastore.uris", "thrift://127.0.0.1:11111")
+ .config("spark.ui.enabled", "false")
+ .config("hive.metastore.connect.retries", "1")
Review Comment:
I think the purpose of this configuration is to allow for fast failure in
order to save some test time, right? Even without this modification, the test
can still succeed, correct?
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreLazyInitializationSuite.scala:
##########
@@ -32,6 +32,8 @@ class HiveMetastoreLazyInitializationSuite extends
SparkFunSuite {
.master("local[2]")
.enableHiveSupport()
.config("spark.hadoop.hive.metastore.uris", "thrift://127.0.0.1:11111")
+ .config("spark.ui.enabled", "false")
+ .config("hive.metastore.connect.retries", "1")
Review Comment:
I think the purpose of this configuration is to allow for fast failure in
order to save some test time, right? Even without this change, the test can
still succeed, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
