panbingkun commented on code in PR #44503: URL: https://github.com/apache/spark/pull/44503#discussion_r1436943860
########## sql/api/src/main/scala/org/apache/spark/sql/errors/DataTypeErrors.scala: ########## @@ -27,7 +27,7 @@ import org.apache.spark.unsafe.types.UTF8String /** * Object for grouping error messages from (most) exceptions thrown during query execution. * This does not include exceptions thrown during the eager execution of commands, which are - * grouped into [[QueryCompilationErrors]]. Review Comment: From the perspective of module dependency, it seems to express the meaning of `CompilationErrors` in the `sql/api` module, instead of `QueryCompilationErrors` in the `sql/catalyst` module. Or we can write it as: `[[CompilationErrors]] and [[QueryCompilationErrors]]` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
