MaxGekk commented on code in PR #44508:
URL: https://github.com/apache/spark/pull/44508#discussion_r1437158897
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -2256,6 +2256,12 @@
],
"sqlState" : "42613"
},
+ "INVALID_SAVE_MODE" : {
+ "message" : [
+ "The specified save mode '<mode>' is invalid. Valid save modes include
'append', 'overwrite', 'ignore', 'error', 'errorifexists', and 'default'."
Review Comment:
Let's quite the option values by default "":
```suggestion
"The specified save mode <mode> is invalid. Valid save modes include
\"append\", \"overwrite\", \"ignore\", \"error\", \"errorifexists\", and
\"default\"."
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -3184,6 +3184,13 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
"config" -> SQLConf.LEGACY_PATH_OPTION_BEHAVIOR.key))
}
+ def invalidSaveModeError(saveMode: String): Throwable = {
+ new AnalysisException(
+ errorClass = "INVALID_SAVE_MODE",
+ messageParameters = Map("mode" -> saveMode)
Review Comment:
Please, quote it by `toDSOption()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
