yaooqinn commented on code in PR #44509:
URL: https://github.com/apache/spark/pull/44509#discussion_r1437327456
##########
project/SparkBuild.scala:
##########
@@ -415,8 +415,7 @@ object SparkBuild extends PomBuild {
/* Protobuf settings */
enable(SparkProtobuf.settings)(protobuf)
- // SPARK-14738 - Remove docker tests from main Spark build
- // enable(DockerIntegrationTests.settings)(dockerIntegrationTests)
+ enable(DockerIntegrationTests.settings)(dockerIntegrationTests)
Review Comment:
I wonder why it was commented out before. The docker-integration-tests is an
optional profile disabled by default. If this is commented out, when will
`guava-18.0` be activated? Only thing I can guess is that the guava code is
untouched by spotify at all.
As for now, if we separate this to a post-proceed PR, we are not able to
pass this one?
```java
[info] org.apache.spark.sql.jdbc.MariaDBKrbIntegrationSuite *** ABORTED ***
(716 milliseconds)
[info] java.lang.NoClassDefFoundError:
com/google/common/collect/MultimapBuilder
[info] at
com.github.dockerjava.core.DefaultDockerCmdExecFactory$DefaultWebTarget.<init>(DefaultDockerCmdExecFactory.java:57)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
