heyihong commented on code in PR #44468:
URL: https://github.com/apache/spark/pull/44468#discussion_r1437686234
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -181,7 +182,12 @@ private[connect] object ErrorUtils extends Logging {
}
val errorClass = e.getErrorClass
if (errorClass != null && errorClass.nonEmpty) {
- errorInfo.putMetadata("errorClass", errorClass)
+ val messageParameters = JsonMethods.compact(
+
JsonMethods.render(map2jvalue(e.getMessageParameters.asScala.toMap)))
+ if (messageParameters.length <= maxMetadataSize) {
+ errorInfo.putMetadata("errorClass", errorClass)
+ errorInfo.putMetadata("messageParameters", messageParameters)
Review Comment:
> The issue might be solved by sending old and new parameters together but
if you send nothing, you don't have any chance.
BTW, maintaining backward compatibility of a ~7k LOC
[error-classes.json](https://github.com/apache/spark/blob/master/common/utils/src/main/resources/error/error-classes.json)
that is changing constantly can be a challenge...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
