WweiL commented on code in PR #44076:
URL: https://github.com/apache/spark/pull/44076#discussion_r1437953371
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala:
##########
@@ -637,18 +653,22 @@ case class StreamingSymmetricHashJoinExec(
thisRow: UnsafeRow,
subIter: Iterator[InternalRow])
extends CompletionIterator[InternalRow, Iterator[InternalRow]](subIter) {
-
+ // scalastyle:off
private val iteratorNotEmpty: Boolean = super.hasNext
override def completion(): Unit = {
val isLeftSemiWithMatch =
joinType == LeftSemi && joinSide == LeftSide && iteratorNotEmpty
// Add to state store only if both removal predicates do not match,
// and the row is not matched for left side of left semi join.
+ println(s"!stateKeyWatermarkPredicateFunc(key):
${!stateKeyWatermarkPredicateFunc(key)}" +
+ s" !stateValueWatermarkPredicateFunc(thisRow):
${!stateValueWatermarkPredicateFunc(thisRow)}")
val shouldAddToState =
!stateKeyWatermarkPredicateFunc(key) &&
!stateValueWatermarkPredicateFunc(thisRow) &&
!isLeftSemiWithMatch
if (shouldAddToState) {
+ println(s"wei==add to state: $thisRow")
Review Comment:
stateKeyWatermarkPredicateFunc's wm should be 0 here, not 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
